On Fri, 28 Jan 2022 at 07:46, Thomas Köller <thomas@xxxxxxxxxxxxxxxxxx>
wrote:
> thanks for the pointer. However, after reading the document it is
> unclear to me what I should have done differently - can you please give
> a hint? Is it that I should have used bugzilla?
>
In this case either is fine. Bugzilla is preferable for anything
non-trivial (having all of the context in one place helps, especially if
it's something that needs rework, we can't look at for a while or needs
tracking over time).
For this specific diff: in most cases we put the required includes in the
.c file. Is there some case where your change is needed to compile?
--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
