On Fri, 2018-08-17 at 10:56 -0700, Darren Tucker wrote: > On 17 August 2018 at 10:45, Darren Tucker <dtucker@xxxxxxxxxxx> > wrote: > > On 17 August 2018 at 08:21, Jeff Wieland <wieland@xxxxxxxxxx> > > wrote: > > > On SPARC Solaris 10, using Solaris' native OpenSSL and Solaris > > > Studio 12.2, I got the following errors: > > > > > > > > > run test agent-getpeereid.sh ... > > > ssh-add did not fail for nobody: 1 < 2 > > > > I'm not sure why this might be. It passes for me on Solaris 10 x86 > > with gcc. I suggest adding a "set -x" at the start of > > agent-getpeereid.sh and running the test ("make tests > > LTESTS=agent-getpeereid.sh SKIP_UNIT=1") and see what it's doing > > under > > the covers. > > Correction on the command: you'll need to also set SUDO: > SUDO=sudo make tests SKIP_UNIT=1 LTESTS=agent-getpeereid Please, document these missing environment variables in the README.regress file. Every time I search for their names and their usage, I have to go through the Makefile. I hope I covered all the missing in the attached patch, but feel free to improve the patch or add more missing. ----------------------------------------------------------------------- diff --git a/regress/README.regress b/regress/README.regress index 86785501..aee3e3c2 100644 --- a/regress/README.regress +++ b/regress/README.regress @@ -33,6 +33,10 @@ TEST_SSH_SSH_CONFOPTS: Configuration directives to be added to ssh_config before running each test. TEST_SSH_SSHD_CONFOPTS: Configuration directives to be added to sshd_config before running each test. +SKIP_UNIT: Skip unit tests. +USE_VALGRIND: Run the tests under valgrind memory checker. +LTESTS: Space separated list of of tests (filenames without the .sh extension) + to run. Individual tests. ----------------------------------------------------------------------- Thanks, -- Jakub Jelen Software Engineer Security Technologies Red Hat, Inc. _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev