On 17 August 2018 at 10:45, Darren Tucker <dtucker@xxxxxxxxxxx> wrote:
> On 17 August 2018 at 08:21, Jeff Wieland <wieland@xxxxxxxxxx> wrote:
>> On SPARC Solaris 10, using Solaris' native OpenSSL and Solaris
>> Studio 12.2, I got the following errors:
>>
>>
>> run test agent-getpeereid.sh ...
>> ssh-add did not fail for nobody: 1 < 2
>
> I'm not sure why this might be. It passes for me on Solaris 10 x86
> with gcc. I suggest adding a "set -x" at the start of
> agent-getpeereid.sh and running the test ("make tests
> LTESTS=agent-getpeereid.sh SKIP_UNIT=1") and see what it's doing under
> the covers.
Correction on the command: you'll need to also set SUDO:
SUDO=sudo make tests SKIP_UNIT=1 LTESTS=agent-getpeereid
For comparision here's the output from my system:
[dtucker@sol10]$ SUDO=sudo make tests SKIP_UNIT=1 LTESTS=agent-getpeereid
[make output snipped]
run test agent-getpeereid.sh ...
++ tid='disallow agent attach from other uid'
++ UNPRIV=nobody
++ ASOCK=/home/dtucker/openssh/upstream/openssh/build/sol10/regress/agent
++ SSH_AUTH_SOCK=/nonexistent
++ config_defined HAVE_GETPEEREID HAVE_GETPEERUCRED HAVE_SO_PEERCRED
++ str=HAVE_GETPEEREID
++ test xHAVE_GETPEERUCRED '!=' x
++ str='HAVE_GETPEEREID|HAVE_GETPEERUCRED'
++ shift
++ test xHAVE_SO_PEERCRED '!=' x
++ str='HAVE_GETPEEREID|HAVE_GETPEERUCRED|HAVE_SO_PEERCRED'
++ shift
++ test x '!=' x
++ egrep '^#define.*(HAVE_GETPEEREID|HAVE_GETPEERUCRED|HAVE_SO_PEERCRED)'
/home/dtucker/openssh/upstream/openssh/build/sol10/config.h
++ :
++ case "x$SUDO" in
++ sudo=1
++ trace 'start agent'
++ start_debug_log start agent
++ echo 'trace: start' agent
++ echo 'trace: start' agent
++ echo 'trace: start' agent
++ '[' X = Xyes ']'
+++ /home/dtucker/openssh/upstream/openssh/build/sol10/ssh-agent -s -a
/home/dtucker/openssh/upstream/openssh/build/sol10/regress/agent
++ eval 'SSH_AUTH_SOCK=/home/dtucker/openssh/upstream/openssh/build/sol10/regress/agent;'
export 'SSH_AUTH_SOCK;' 'SSH_AGENT_PID=8814;' export 'SSH_AGENT_PID;'
echo Agent pid '8814;'
+++ SSH_AUTH_SOCK=/home/dtucker/openssh/upstream/openssh/build/sol10/regress/agent
+++ export SSH_AUTH_SOCK
+++ SSH_AGENT_PID=8814
+++ export SSH_AGENT_PID
+++ echo Agent pid 8814
++ r=0
++ '[' 0 -ne 0 ']'
++ chmod 644 /home/dtucker/openssh/upstream/openssh/build/sol10/regress/agent
++ /home/dtucker/openssh/upstream/openssh/build/sol10/ssh-add -l
++ r=1
++ '[' 1 -ne 1 ']'
++ test -z 1
++ sudo -S -u nobody
/home/dtucker/openssh/upstream/openssh/build/sol10/ssh-add -l
++ r=2
++ '[' 2 -lt 2 ']'
++ trace 'kill agent'
++ start_debug_log kill agent
++ echo 'trace: kill' agent
++ echo 'trace: kill' agent
++ echo 'trace: kill' agent
++ '[' X = Xyes ']'
++ /home/dtucker/openssh/upstream/openssh/build/sol10/ssh-agent -k
++ rm -f /home/dtucker/openssh/upstream/openssh/build/sol10/regress/agent
+ cleanup
+ '[' x '!=' x ']'
+ '[' x '!=' x ']'
+ stop_sshd
+ '[' -f /home/dtucker/openssh/upstream/openssh/build/sol10/regress/pidfile ']'
+ '[' 0 -eq 0 ']'
+ verbose ok disallow agent attach from other uid
+ start_debug_log ok disallow agent attach from other uid
+ echo 'trace: ok' disallow agent attach from other uid
+ echo 'trace: ok' disallow agent attach from other uid
+ echo 'trace: ok' disallow agent attach from other uid
+ '[' X '!=' Xyes ']'
+ echo ok disallow agent attach from other uid
ok disallow agent attach from other uid
+ exit 0
make[1]: Leaving directory `/home/dtucker/openssh/upstream/openssh/regress'
all tests passed
>
> --
> Darren Tucker (dtucker at dtucker.net)
> GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
> Good judgement comes with experience. Unfortunately, the experience
> usually comes from bad judgement.
--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
