port-solaris.c:218: bad compare ?

[David Binderman <dcb314@xxxxxxxxxxx>]

Hello there,


port-solaris.c:218]: (style) A pointer can not be negative so it is either pointless or an error to check if it is not.

Source code is

    if ((defaultproject = getdefaultproj(pw->pw_name, &tempproject, &buf,
        sizeof(buf))) > 0) {

Maybe better code

    if ((defaultproject = getdefaultproj(pw->pw_name, &tempproject, &buf,
        sizeof(buf))) != 0) {

Regards

David Binderman



_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev