On 26/05/15 01.50, Peter Stuge wrote:
> Kasper Dupont wrote:
> > +send_client_banner(int connection_out, int minor1, const char *host)
> > {
> > /* Send our own protocol version identification. */
> > if (compat20) {
> > - xasprintf(&client_version_string, "SSH-%d.%d-%.100s\r\n",
> > - PROTOCOL_MAJOR_2, PROTOCOL_MINOR_2, SSH_VERSION);
> > + xasprintf(&client_version_string,
> > + "SSH-%d.%d-%.100s {\"SNI\": \"%.133s\"}\r\n",
> > + PROTOCOL_MAJOR_2, PROTOCOL_MINOR_2, SSH_VERSION, host);
>
> You propose introducing JSON injection. Really?
Felt like a better idea than XML.
>
> Aside from all the other valid criticism, JSON is a bad fit.
Frankly. I don't care about the format. JSON was the best
I could come up with given that it is supposed to be human
readable and it is a good idea to use an established
standard which is extensible.
If you can suggest a better format, I'd happily change it.
--
Kasper Dupont -- Rigtige mænd skriver deres egne backupprogrammer
#define _(_)"d.%.4s%."_"2s" /* This is my email address */
char*_="@2kaspner"_()"%03"_("4s%.")"t\n";printf(_+11,_+6,_,12,_+2,_+7,_+6);
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
