Re: Name based SSH proxy

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

 



Kasper Dupont wrote:
> +send_client_banner(int connection_out, int minor1, const char *host)
>  {
>  	/* Send our own protocol version identification. */
>  	if (compat20) {
> -		xasprintf(&client_version_string, "SSH-%d.%d-%.100s\r\n",
> -		    PROTOCOL_MAJOR_2, PROTOCOL_MINOR_2, SSH_VERSION);
> +		xasprintf(&client_version_string,
> +		    "SSH-%d.%d-%.100s {\"SNI\": \"%.133s\"}\r\n",
> +		    PROTOCOL_MAJOR_2, PROTOCOL_MINOR_2, SSH_VERSION, host);

You propose introducing JSON injection. Really?

Aside from all the other valid criticism, JSON is a bad fit.


//Peter
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev




[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux