Forgot to include the patch ... completely berking it today ...
On Tue, Aug 19, 2014 at 3:04 PM, Kevin Brott <kevin.brott@xxxxxxxxx> wrote:
>
> Oh dear ... it is to laugh .. I just realized what the problem is. This
> is the failing compile example ...
>
> gcc -o regress/unittests/sshbuf/test_sshbuf -L. -Lopenbsd-compat/
> -Wl,-blibpath:/opt/phs/lib:/opt/freeware/lib:/usr/lib:/usr/ccs/lib
> -L/opt/phs/lib -L/opt/freeware/lib -L/usr/lib -L/usr/ccs/lib
> -Wl,-blibpath:/usr/lib:/lib regress/unittests/sshbuf/tests.o
> regress/unittests/sshbuf/test_sshbuf.o
> regress/unittests/sshbuf/test_sshbuf_getput_basic.o
> regress/unittests/sshbuf/test_sshbuf_getput_crypto.o
> regress/unittests/sshbuf/test_sshbuf_misc.o
> regress/unittests/sshbuf/test_sshbuf_fuzz.o
> regress/unittests/sshbuf/test_sshbuf_getput_fuzz.o
> regress/unittests/sshbuf/test_sshbuf_fixed.o \
> * -L regress/unittests/test_helper -ltest_helper \*
> -lssh -lopenbsd-compat -lssh -lopenbsd-compat -lcrypto -lz -lpthread
> collect2: library libtest_helper not found
>
> The space between -L and the directory is what's causing the issue. the
> correct line would be
> * -Lregress/unittests/test_helper -ltest_helper \*
>
> Should fixed be a simple edit in the Makefile.in ... I'm surprised this
> isn't broken elsewhere for the same reason.
>
>
>
> On Tue, Aug 19, 2014 at 2:14 PM, Kevin Brott <kevin.brott@xxxxxxxxx>
> wrote:
>
>> AIX6/7 + gcc 4.2.0/4.4.7 passes all tests fine with the library
>> explicitly substituted for the -L -l construct. I'll work out a patch that
>> does this automagically as soon as I work out where it should go, unless
>> someone has a better idea
>>
>> AIX native, HPX gcc+native, and Debian builds all continue to build/test.
>>
>>
>> On Tue, Aug 19, 2014 at 12:55 PM, Kevin Brott <kevin.brott@xxxxxxxxx>
>> wrote:
>>
>>> FAIL*1 on Centos 2.1 -> RHEL 5.10
>>> FAIL*2 on RHEL 6.0 -> RHEL 6.4 and AIX 5.3 (using openssl 0.9.8k)
>>>
>>> The AIX gcc builds are still failing, but - if I replace this line:
>>> -L regress/unittests/test_helper -ltest_helper \
>>> With this
>>> regress/unittests/test_helper/libtest_helper.a \
>>> ....
>>> then test_sshbuf and test_sshkey compile ok (both fail for the 'missing'
>>> library) - and tests continue ... will report status when run is done.
>>>
>>>
>>>
>>> On Tue, Aug 19, 2014 at 8:54 AM, Kevin Brott <kevin.brott@xxxxxxxxx>
>>> wrote:
>>>
>>>>
>>>> New failures on older openssl ... will test against the RH 1.0.0-fips
>>>> in a bit ...
>>>>
>>>> Using http://www.mindrot.org/openssh_snap/openssh-SNAP-20140820.tar.gz
>>>>
>>>> OS Build_Target CC
>>>> OpenSSL BUILD TEST
>>>> ============== =========================== ================
>>>> ============= ====== =================
>>>> Centos 2.1 i386-redhat-linux gcc 2.9.6
>>>> 0.9.6b-engine FAIL*1
>>>> RHEL 3.4 i386-redhat-linux gcc 3.2.3-47
>>>> 0.9.7a FAIL*1
>>>> AIX 5300-12-04 powerpc-ibm-aix5.3.0.0 gcc 4.2.0-3
>>>> 0.9.8k FAIL*2
>>>>
>>>> FAIL*1 - Shouldn't this have been caught by configure?
>>>> gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare
>>>> -Wformat-security -fno-strict-aliasing -D_FORTIFY_SOURCE=2
>>>> -fno-builtin-memset -std=gnu99 -I. -I.. -I. -I./.. -DHAVE_CONFIG_H -c
>>>> openssl-compat.c
>>>> In file included from openssl-compat.c:32:
>>>> openssl-compat.h:28:2: #error OpenSSL 0.9.8f or greater is required
>>>> make[1]: *** [openssl-compat.o] Error 1
>>>> make[1]: Leaving directory `/usr/src/openssh/openbsd-compat'
>>>> make: *** [openbsd-compat/libopenbsd-compat.a] Error 2
>>>>
>>>> FAIL*2 - Different AIX failure on old openssl ...
>>>> gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized
>>>> -Wsign-compare -Wformat-security -Wno-pointer-sign -fno-strict-aliasing
>>>> -D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -I. -I.. -I. -I./..
>>>> -DHAVE_CONFIG_H -c port-aix.c
>>>> In file included from ../key.h:29,
>>>> from port-aix.c:31:
>>>> ../sshkey.h:34:24: error: openssl/ec.h: No such file or directory
>>>> In file included from ../key.h:29,
>>>> from port-aix.c:31:
>>>> ../sshkey.h:103: error: expected specifier-qualifier-list before
>>>> 'EC_KEY'
>>>> ../sshkey.h:149: error: expected ')' before '*' token
>>>> ../sshkey.h:151: warning: type defaults to 'int' in declaration of
>>>> 'EC_GROUP'
>>>> ../sshkey.h:151: error: expected ';', ',' or ')' before '*' token
>>>> ../sshkey.h:152: warning: type defaults to 'int' in declaration of
>>>> 'EC_KEY'
>>>> ../sshkey.h:152: error: expected ';', ',' or ')' before '*' token
>>>> ../sshkey.h:170: warning: type defaults to 'int' in declaration of
>>>> 'EC_GROUP'
>>>> ../sshkey.h:170: error: expected ';', ',' or ')' before '*' token
>>>> ../sshkey.h:171: warning: type defaults to 'int' in declaration of
>>>> 'EC_KEY'
>>>> ../sshkey.h:171: error: expected ';', ',' or ')' before '*' token
>>>> In file included from port-aix.c:31:
>>>> ../key.h:85: warning: type defaults to 'int' in declaration of
>>>> 'EC_GROUP'
>>>> ../key.h:85: error: expected ';', ',' or ')' before '*' token
>>>> ../key.h:86: warning: type defaults to 'int' in declaration of
>>>> 'EC_KEY'
>>>> ../key.h:86: error: expected ';', ',' or ')' before '*' token
>>>> make: The error code from the last command is 1.
>>>>
>>>>
>>>>
>>>>
>>>> On Mon, Aug 18, 2014 at 9:26 PM, Damien Miller <djm@xxxxxxxxxxx> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Mon, 18 Aug 2014, Kevin Brott wrote:
>>>>>
>>>>> > Will test this out in the morning. Will this be in the 0820
>>>>> snapshot?
>>>>>
>>>>> Yes, it should be.
>>>>>
>>>>> -d
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> # include <stddisclaimer.h>
>>>> /* Kevin Brott <Kevin.Brott@xxxxxxxxx> */
>>>>
>>>>
>>>
>>>
>>> --
>>> # include <stddisclaimer.h>
>>> /* Kevin Brott <Kevin.Brott@xxxxxxxxx> */
>>>
>>>
>>
>>
>> --
>> # include <stddisclaimer.h>
>> /* Kevin Brott <Kevin.Brott@xxxxxxxxx> */
>>
>>
>
>
> --
> # include <stddisclaimer.h>
> /* Kevin Brott <Kevin.Brott@xxxxxxxxx> */
>
>
--
# include <stddisclaimer.h>
/* Kevin Brott <Kevin.Brott@xxxxxxxxx> */
*** openssh/Makefile.in 2014-07-18 13:33:12.000000000 -0700
--- openssh-fix/Makefile.in 2014-08-19 15:25:02.304857273 -0700
***************
*** 457,461 ****
regress/unittests/test_helper/libtest_helper.a libssh.a
$(LD) -o $@ $(LDFLAGS) $(UNITTESTS_TEST_SSHBUF_OBJS) \
! -L regress/unittests/test_helper -ltest_helper \
-lssh -lopenbsd-compat -lssh -lopenbsd-compat $(LIBS)
--- 457,461 ----
regress/unittests/test_helper/libtest_helper.a libssh.a
$(LD) -o $@ $(LDFLAGS) $(UNITTESTS_TEST_SSHBUF_OBJS) \
! -Lregress/unittests/test_helper -ltest_helper \
-lssh -lopenbsd-compat -lssh -lopenbsd-compat $(LIBS)
***************
*** 470,474 ****
regress/unittests/test_helper/libtest_helper.a libssh.a
$(LD) -o $@ $(LDFLAGS) $(UNITTESTS_TEST_SSHKEY_OBJS) \
! -L regress/unittests/test_helper -ltest_helper \
-lssh -lopenbsd-compat -lssh -lopenbsd-compat $(LIBS)
--- 470,474 ----
regress/unittests/test_helper/libtest_helper.a libssh.a
$(LD) -o $@ $(LDFLAGS) $(UNITTESTS_TEST_SSHKEY_OBJS) \
! -Lregress/unittests/test_helper -ltest_helper \
-lssh -lopenbsd-compat -lssh -lopenbsd-compat $(LIBS)
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
