On Tue, 2017-08-15 at 09:09 -0700, Daniel Lenski wrote: > On Tue, Aug 15, 2017 at 7:45 AM, David Woodhouse <dwmw2 at infradead.org> wrote: > >? > > Thanks. I've pushed them to a 'gpst' branch, and started adding commits > > on top which are a mixture of fixes, pandering to my own pedantry and > > preferred style, review comments and just plain heckling... :) > > Great. Thanks for doing the memory cleanups. Are you doing this with > an automated tool, or do you just have a very keen eye for where > malloc() can fail? The latter :) > UA-mangling: I had thought about doing this something like what you > settled on, or adding a per-protocol override, and then decided that > was overkill. Yeah, doing it manually is fine but this way we can do it manually in just one place. > Token generation: I think you are right that can_gen_tokencode() is > needed. Will send a patch for that shortly. > > I also realized that one late-breaking improvement to the login > argument handling discovered by a user on Github wasn't included. So? > one more patch incoming. OK. I'll keep on reading and heckling... ?:) -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 4938 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20170815/48f38eb0/attachment.bin>
