On Tue, Aug 15, 2017 at 7:45 AM, David Woodhouse <dwmw2 at infradead.org> wrote: > On Mon, 2017-08-14 at 21:34 -0700, Daniel Lenski wrote: >> I've sent updated versions of patches 2, 3, 7, and 8 from the series >> (matching the latest GP support from >> https://github.com/dlenski/openconnect/tree/globalprotect/). >> >> The list won't see [PATCH v2 3/8], since it exceeds the size limit, >> unless manually moderated in? > > Thanks. I've pushed them to a 'gpst' branch, and started adding commits > on top which are a mixture of fixes, pandering to my own pedantry and > preferred style, review comments and just plain heckling... :) Great. Thanks for doing the memory cleanups. Are you doing this with an automated tool, or do you just have a very keen eye for where malloc() can fail? UA-mangling: I had thought about doing this something like what you settled on, or adding a per-protocol override, and then decided that was overkill. Token generation: I think you are right that can_gen_tokencode() is needed. Will send a patch for that shortly. I also realized that one late-breaking improvement to the login argument handling discovered by a user on Github wasn't included. So? one more patch incoming. -Dan
