[PATCH] Problem: [OSX] libpcsclite is listed as required library in openconnect.pc.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



When compiling under OSX, openconnect.pc has libpcsclite listed as dependency.
Unfortunately there is no such library under OSX as OSX's own framework is
used. This is kind of a nuisance as other projects (e.g. openconnect-gui) are
unable to build as pkg-config is unable to find all required libraries.

Workarounds:
1.) use --without-libpcsclite which means no Yubikey support.
2.) Install a package manager (e.g. Homebrew) and install pcsc-lite as
  package. As a result suitable libraries are installed.

Preferred solution:
An alteration to configure.ac. Check if LIBPCSCLITE_LIBS (defined on line 62)
is altered when compiling on OSX. If so, act accordingly.

Signed-off-by: Bj?rn Ketelaars <bjorn.ketelaars at hydroxide.nl>
---
 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git configure.ac configure.ac
index fcb2bad..61d0959 100644
--- configure.ac
+++ configure.ac
@@ -683,7 +683,8 @@ AC_ARG_WITH([libpcsclite],
 	[Build without libpcsclite library (for Yubikey support) [default=auto]]))
 AS_IF([test "x$with_libpcsclite" != "xno"], [
 	PKG_CHECK_MODULES(LIBPCSCLITE, libpcsclite,
-			[AC_SUBST(LIBPCSCLITE_PC, libpcsclite)
+			[AS_IF([test "$host_os" != "*darwin*" -a "x$LIBPCSCLITE_LIBS" != "x-Wl,-framework -Wl,PCSC"],
+				[AC_SUBST(LIBPCSCLITE_PC, libpcsclite)])
 			 AC_DEFINE([HAVE_LIBPCSCLITE], 1, [Have libpcsclite])
 			 libpcsclite_pkg=yes],
 			 libpcsclite_pkg=no)
-- 
2.8.4 (Apple Git-73)




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux