Re: [PATCH] fs/ntfs3: clarify emitted log message when marking volumes as dirty

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 26, 2021 at 11:53:46PM +0300, Kari Argillander wrote:
> On Tue, Oct 26, 2021 at 10:49:22PM +0200, Enrico Mioso wrote:
> > We are actually marking the volume as dirty. Reflect this in the message.
> 
> Again this should look like below. Maybe send patch series which contains
> both of your patches. Mark it as v2.

And please also cc linux-kernel@xxxxxxxxxxxxxxx

And to: should be also 
Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>

> 
> We are actually marking the volume as dirty. Reflect this in the
> message.
> 
> I have not strong opinion about this change so I let Konstantin decide.
> 
> > Signed-off-by: Enrico Mioso <mrkiko.rs@xxxxxxxxx>
> > ---
> >  fs/ntfs3/fsntfs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c
> > index abe74dc9ce31..08802d7ca078 100644
> > --- a/fs/ntfs3/fsntfs.c
> > +++ b/fs/ntfs3/fsntfs.c
> > @@ -933,7 +933,7 @@ int ntfs_set_state(struct ntfs_sb_info *sbi, enum NTFS_DIRTY_FLAGS dirty)
> >  
> >  	switch (dirty) {
> >  	case NTFS_DIRTY_ERROR:
> > -		ntfs_notice(sbi->sb, "Mark volume as dirty due to NTFS errors");
> > +		ntfs_notice(sbi->sb, "Marking volume as dirty due to NTFS errors");
> >  		sbi->volume.real_dirty = true;
> >  		fallthrough;
> >  	case NTFS_DIRTY_DIRTY:
> > -- 
> > 2.33.1
> > 
> > 
> 




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux