On 02.09.2021 11:10, Kari Argillander wrote: > On Wed, Sep 01, 2021 at 09:22:19PM -0700, Joe Perches wrote: >> On Tue, 2021-08-31 at 21:15 +0300, Kari Argillander wrote: >>> Use consistent spacing around '+' for better code reading. Checkpatch >>> will also be happy. >> >> I think you should remove the + instead > > Konstantin can you look this as this was introduce by you just couple > days ago? > >> >>> diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c >> [] >>> @@ -1451,7 +1451,7 @@ int ni_insert_resident(struct ntfs_inode *ni, u32 data_size, >>> attr->res.flags = RESIDENT_FLAG_INDEXED; >>> >>> >>> /* is_attr_indexed(attr)) == true */ >>> - le16_add_cpu(&ni->mi.mrec->hard_links, +1); >>> + le16_add_cpu(&ni->mi.mrec->hard_links, + 1); >> >> le16_add_cpu(&ni->mi.mrec->hard_links, 1); >> >> Hi, Kari, Joe! Yes, '+' can be removed, it was added for better visibility, but it's subjective. After checking code - it's the only place with '+1', so let's remove it.
