Many new checkpatch warnings have been introduce to ntfs3. These could have been prevent if checkpatch is used. One thing that worrys me is that Konstantin puts new code without code reviewing process to ntfs3. Patch commit message says one thing, but one huge patch address that and lot of just refactoring code. Also with review process we can prevent these kind of silly checkpatch mistakes. Kmalloc_array was my fault for some reason checkpatch did not show those. I have no idea how, but I just fix it now and be very ashamed. You should also Konstantin use checkpatch always before push so you can spot these things before hand. I will try to get CI going for patches. Kari Argillander (5): fs/ntfs3: Use kmalloc_array over kmalloc with multiply fs/ntfs3: Use consistent spacing around '+' fs/ntfs3: Place Comparisons constant right side of the test fs/ntfs3: Remove braces from single statment block fs/ntfs3: Remove tabs before spaces from comment fs/ntfs3/bitmap.c | 2 +- fs/ntfs3/frecord.c | 8 ++++---- fs/ntfs3/index.c | 4 ++-- fs/ntfs3/lznt.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) base-commit: d3624466b56dd5b1886c1dff500525b544c19c83 -- 2.25.1
