On 3/21/24 00:27, Timur Tabi wrote:
On Mon, 2024-03-04 at 13:57 +0100, Danilo Krummrich wrote:
Thanks for sending a new version of the patch.
Please make sure that for future patches you include a changelog, such that
it's easier for reviewers to keep track of what has changed.
Will do.
.../gpu/drm/nouveau/include/nvkm/subdev/gsp.h | 6 +
.../gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 375 ++++++++++++++++--
2 files changed, 357 insertions(+), 24 deletions(-)
There are a few issues pointed out by checkpatch.pl, that I think should be fixed.
checkpatch showed me nothing:
$ scripts/checkpatch.pl 0001-v4-nouveau-add-command-line-GSP-RM-registry-
support.patch
total: 0 errors, 0 warnings, 420 lines checked
0001-v4-nouveau-add-command-line-GSP-RM-registry-support.patch has no
obvious style problems and is ready for submission.
I used '--strict'. I think we should get the kmalloc(), the blank lines and the
alignment ones fixed.
- Danilo
