Re: NNTPC: Minor 0.87.9 problems (still in 88.1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Well, I finally inadvertently discovered it. I had added the IP address
> to the log message for refused connections and discovered that when
> the name is empty the address it is using is 127.0.0.1. I'm not sure
> why it thinks that sometimes the connection is local as the machine it 
> is running on has no user accounts. If I had not taken 127.0.0.1 out
> of the access file I may never have caught it. 

Bizarre. acc.c gets the inet addr like so:

getpeername (sock, (struct sockaddr *) &remote_sin, &sinlen)
[...]
strncpy (themaddr, inet_ntoa (remote_sin.sin_addr), themlen);

I can't see how 127.0.0.1 is making its way in as the source address
unless that is what your network kernel actually believes.

> The other odd thing is that even though nntpcached is running on a 
> machine outside our firewall and all connections come from the same
> proxy host (the firewall), only certain people get the 'connection
> refused' message since I disabled 127.0.0.1 from the access file.

I've refreshed acc.c a little just now. Mainly cosmetic changes.
The blank client host in the logs is now gone (if reverse dns
failed you would see this problem).

> Also, the error message passed to the reader on refused connection
> is unsuitable for commercial use. Fortunately, many readers just
> report an error and don't pass the text to the user. I'm sure some
> VP would be real excited about seeing "your not good enough to be
> in the access file. ack. ack" message.

Maybe we can make a fortune cookie file for the english messages.
"cat aliens ate my psychodelic toad stool and now I can't find the 
the button for the drawbridge". Sounds good. Any seconders?

> log (("refused connect from %s address %s",ClientHost, ClientHostAddr));

ClientHostNormal is now ClientHost which is now the best choice given
what is available out of ClientHostAddrRFC931 etc.

-- 
"Of all tyrannies a tyranny sincerely  exercised for the good of its victims  
 may be the most  oppressive.  It may be better to live under  robber barons  
 than  under  omnipotent  moral busybodies,  The robber baron's  cruelty may  
 sometimes sleep,  his cupidity may at some point be satiated; but those who  
 torment us for own good  will torment us  without end,  for they do so with 
 the approval of their own conscience."    -   C.S. Lewis, _God in the Dock_ 
+---------------------+--------------------+----------------------------------+
|Julian Assange RSO   | PO Box 2031 BARKER | Secret Analytic Guy Union        |
|proff@suburbia.net   | VIC 3122 AUSTRALIA | finger for PGP key hash ID =     |
|proff@gnu.ai.mit.edu | FAX +61-3-98199066 | 0619737CCC143F6DEA73E27378933690 |
+---------------------+--------------------+----------------------------------+


[Index of Archives]     [Yosemite]     [Yosemite Campsites]     [Bugtraq]     [Linux]     [Trn]

Powered by Linux