Re: NNTPC: nntpcache-0.91.0 make problems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> The new release does not build 'out of the box' on my linux
> test machine. In the dbz directory make dies with a 'no rule
> to make ../nntpcache.h' error. I just deleted that dependency
> from the  $(OBJS) : rule to get it to compile, realizing I 
> would have to do a 'make clean' before a remake if I edited
> nntpcache.h.
>    Then it failed compiling dbz.c because of
> In file included from dbz.c:3:
> ../nntpcache.h:10: nntpconfig.h: No such file or directory
>   This was the file that undef'd mmap in the previous versions
> but is not present in the current version. After commenting out
> that include in nntpcache.h the build completed successfully.

I removed it at the last minute. I've fixed this (see beflow).

> Other possible bugs:
>   In expire.c, there is an #if at the top that checks whether
> you are using statfs or statvfs, but then also calls stafs
> again after the #endif (line 19). I think this line should
> be removed.  Also, to be safe, shouldn't you be doing the
> statfs on con.cacheDir instead of "." or is the current
> directory always going to be the spool and not the filesystem
> nntpcached was started from (I haven't gone through all the
> code leading up to the expire check, so I don't know if "." is
> a valid assumption or not).
> 
> frank

"." is correct. the routine is actually recursive, so the "." is
pretty important ;)

Good work on the statfs() problem though, I believe it was
causing some people problems.

-- 
"Of all tyrannies a tyranny sincerely  exercised for the good of its victims  
 may be the most  oppressive.  It may be better to live under  robber barons  
 than  under  omnipotent  moral busybodies,  The robber baron's  cruelty may  
 sometimes sleep,  his cupidity may at some point be satiated; but those who  
 torment us for own good  will torment us  without end,  for they do so with 
 the approval of their own conscience."    -   C.S. Lewis, _God in the Dock_ 
+---------------------+--------------------+----------------------------------+
|Julian Assange RSO   | PO Box 2031 BARKER | Secret Analytic Guy Union        |
|proff@suburbia.net   | VIC 3122 AUSTRALIA | finger for PGP key hash ID =     |
|proff@gnu.ai.mit.edu | FAX +61-3-98199066 | 0619737CCC143F6DEA73E27378933690 |
+---------------------+--------------------+----------------------------------+


[Index of Archives]     [Yosemite]     [Yosemite Campsites]     [Bugtraq]     [Linux]     [Trn]

Powered by Linux