Hi Daniel, On Tue, Mar 28, 2023 at 6:29 AM Daniel Watson <ozzloy@xxxxxxxxx> wrote: > > i am learning from guides like this > https://kernelnewbies.org/FirstKernelPatch#FirstPatch > > i sent an earlier patch, but was told to skip the drivers/staging/media > directory. > > is this an acceptable patch? > Generally, this is an acceptable patch. It might be that the patch is a bit too trivial to be picked up, but staging/rtl8723bs/ is probably a good place to start with trivial patches and have high chances for getting them picked up. Some minor nits below. > is this message double-posting? it looks like my prior message > shows up twice. > Sometimes patches show up multiple times in lore.kernel.org archives, as some mailing list add further footers, so the same content sent is recorded slightly differently in the archives, leading to multiple copies. This is not considered double posting, though, as it is default to send a patch to multiple mailing lists, e.g., specific subsystem mailing list and the general linux-kernel mailing list. As long as the message has the same Message-ID, it is clear they were sent with one "git send-email" invocation. > thanks! > > To: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>,linux-staging@xxxxxxxxxxxxxxx,linux-kernel@xxxxxxxxxxxxxxx > Subject: [PATCH] staging: rtl8723bs: move { onto opening line of if > Usually "{" would be written out as "opening brackets" or as "curly brackets", just having a special character, like "{", is not seen often in commit message subject lines. Usually, consistency beats style. So, check if this pattern appears in any files in drivers/staging/rtl8723bs/ and its subdirectories and try to fix all instances within that directory with one patch. Other than that, it looks like a good newcomer's first submission patch. Lukas > Checkpatch flagged this as a fixable style error. > > Signed-off-by: Daniel Watson <ozzloy@xxxxxxxxx> > --- > drivers/staging/rtl8723bs/include/rtw_recv.h | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/include/rtw_recv.h b/drivers/staging/rtl8723bs/include/rtw_recv.h > index 44f67103503ae..fef2fd0e8c84f 100644 > --- a/drivers/staging/rtl8723bs/include/rtw_recv.h > +++ b/drivers/staging/rtl8723bs/include/rtw_recv.h > @@ -398,8 +398,7 @@ static inline u8 *recvframe_pull(union recv_frame *precvframe, signed int sz) > > precvframe->u.hdr.rx_data += sz; > > - if (precvframe->u.hdr.rx_data > precvframe->u.hdr.rx_tail) > - { > + if (precvframe->u.hdr.rx_data > precvframe->u.hdr.rx_tail) { > precvframe->u.hdr.rx_data -= sz; > return NULL; > } > @@ -425,8 +424,7 @@ static inline u8 *recvframe_put(union recv_frame *precvframe, signed int sz) > > precvframe->u.hdr.rx_tail += sz; > > - if (precvframe->u.hdr.rx_tail > precvframe->u.hdr.rx_end) > - { > + if (precvframe->u.hdr.rx_tail > precvframe->u.hdr.rx_end) { > precvframe->u.hdr.rx_tail = prev_rx_tail; > return NULL; > } > @@ -451,8 +449,7 @@ static inline u8 *recvframe_pull_tail(union recv_frame *precvframe, signed int s > > precvframe->u.hdr.rx_tail -= sz; > > - if (precvframe->u.hdr.rx_tail < precvframe->u.hdr.rx_data) > - { > + if (precvframe->u.hdr.rx_tail < precvframe->u.hdr.rx_data) { > precvframe->u.hdr.rx_tail += sz; > return NULL; > } > -- > 2.34.1 > > > _______________________________________________ > Kernelnewbies mailing list > Kernelnewbies@xxxxxxxxxxxxxxxxx > https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
