On 21/04/26 03:50PM, Leon Romanovsky wrote: > On Mon, Apr 26, 2021 at 02:00:58PM +0200, Rafael J. Wysocki wrote: > > On Mon, Apr 26, 2021 at 6:57 AM Leon Romanovsky <leon@xxxxxxxxxx> wrote: > > > > > > On Fri, Apr 23, 2021 at 03:08:03PM -0600, Shuah Khan wrote: > > > > On 4/22/21 12:03 PM, Anupama K Patil wrote: > > > > > de, e are two variables of the type 'struct proc_dir_entry' > > > > > which can be removed to save memory. This also fixes a coding style > > > > > issue reported by checkpatch where we are suggested to make assignment > > > > > outside the if statement. > > > > > > > > > > > > > Sounds like a reasonable change. > > > > > > It is unclear how much changes to ISA code are welcomed. If changes to ISA code aren't welcomed, should these be marked obsolete in the MAINTIANERS file? > > > > Real fixes and obvious cleanups are, not much more than that. > > While first part is easy to determine, the second one is more blurry. > > > > > > According to the Wikipedia, even Windows Vista disabled ISA PnP by default. > > > https://en.wikipedia.org/wiki/Legacy_Plug_and_Play#Specifications I wasn't aware until after this reply. Sorry about that! thanks, karthik > > > > It is indeed unclear how many systems with this interface still run > > Linux, but as long as the code is in the tree, there's nothing wrong > > with attempting to improve it. There's no assurance that all such > > patches will be applied, though. > > > > Thanks! _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
