On Sun, Mar 21, 2021 at 5:25 PM Harsha Vardhan <harshavardhan3294@xxxxxxxxx> wrote: > > perfect ! I will do it that way then. > > besides that, generally if you are making changes to drivers , then the responsibility of testing is on the author of the patch right ? if you don't have the device how would you test such things ? I would assume other subsystems like memory will have some sort of test suite that gets run automatically to make sure we are not introducing any regressions but confused as to how we ensure the same with drivers. > You already violated the first rule of email netiquette. Do not top post. See more here https://people.kernel.org/tglx/notes-about-netiquette. To your question: It is not required that you have the driver at hand when you make changes. That requirement would make any larger refactoring impossible. You should be able to argue that the change you made is reasonable and does not break any driver that was not already broken before. It is up to the users and driver maintainers to ensure that drivers continue working... Start with some checkpatch fix on staging... and then you will see... Lukas _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies