Re: Please give advise about my first patch attempt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 27, 2020 at 10:49:51AM +0200, Thomas Schmitt wrote:
> Hi,
> 
> i am preparing my first patch.
> May i ask for review and advise how to make it acceptable ?

If you are not running it already you can catch common mistakes by
running checkpatch script from the kernel source top directory like:

  $ ./scripts/checkpatch.pl --strict --codespell -g <commit-id>

Also would suggest to build kernel with warnings treated as errors:

  $ make CFLAGS_KERNEL+=-Werror ...

Thanks,
Pawan

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@xxxxxxxxxxxxxxxxx
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies



[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]

  Powered by Linux