On Sat, Oct 19, 2019 at 10:33:00AM +1300, Paulo Almeida wrote: > Hi all, > > I was reading the KernelJanitor/Todo webpage and found the printk-related > task that had to be done. > > I eventually came across this piece of code that led me to 2 questions that > I couldn't answer myself > https://github.com/torvalds/linux/blame/master/init/do_mounts.c#L434-L455 > > 1 - This specific code block has been around for quite some time and many > additions using the correct printk(KERN_* were made after it was written. > Does that mean that this code block is an exception and should be left > as-is for some technical reason? Or, people have somehow forgotten about it > and I finally found something to do? :) > > 2 - I took a look at the https://www.kernel.org/doc/linux/MAINTAINERS list > and their respective folders/repos and couldn't find out who would be the > person who I should eventually send the patches to. Is there any > "fallthrough" maintainer when there isn't one specified? (Please put me > straight if I'm not seeing things from the right angle) Run scripts/get_maintainer.pl on any file and it will tell you where to send changes to: $ ./scripts/get_maintainer.pl --file init/do_mounts.c Al Viro <viro@xxxxxxxxxxxxxxxxxx> (commit_signer:7/9=78%,authored:5/9=56%,added_lines:7/44=16%,removed_lines:27/32=84%) David Howells <dhowells@xxxxxxxxxx> (commit_signer:3/9=33%,authored:2/9=22%,added_lines:5/44=11%,removed_lines:5/32=16%) Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> (commit_signer:2/9=22%) Nikolaus Voss <nikolaus.voss@xxxxxxxxxxxxxxxxxxxxx> (commit_signer:1/9=11%,authored:1/9=11%,added_lines:31/44=70%) Thomas Gleixner <tglx@xxxxxxxxxxxxx> (commit_signer:1/9=11%,authored:1/9=11%) linux-kernel@xxxxxxxxxxxxxxx (open list) But don't do janitorial cleanup on those files as a "first task". That is what the drivers/staging/ directory is for, don't mess with core kernel files unless you have experience doing kernel changes, as the learning curve needs to be gotten over first. good luck! greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
