Re: checkpatch.pl CHECK alignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alright, thanks for answering

On 02/09/2019, 18:42, "Jefferson Carpenter" <jefferson@xxxxxxxxxxxxx> wrote:

    IMHO formatting reasons are not enough to submit a patch, unless the 
    formatting is really whack.  If it's off by one space, it probably 
    doesn't matter.  Enough lines get changed anyway without the "noise" of 
    re-formatting something.  If you are touching that code anyway or 
    something very near it, then you might go ahead and change the 
    formatting also.
    
    On 9/2/2019 4:17 PM, XenoN. w0w wrote:
    > Hello all, I am running checkpath.pl against one driver and I’m getting
    > CHECK: Alignment should match open parenthesis
    > 
    > Are these lines worth of changing, what are the odds of that patch being accepted. I’m new and I want to contribute so sorry for dumb question
    > 
    > 
    > _______________________________________________
    > Kernelnewbies mailing list
    > Kernelnewbies@xxxxxxxxxxxxxxxxx
    > https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
    > 
    
    
    
    _______________________________________________
    Kernelnewbies mailing list
    Kernelnewbies@xxxxxxxxxxxxxxxxx
    https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
    

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@xxxxxxxxxxxxxxxxx
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies




[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]

  Powered by Linux