On Thu, Feb 22, 2018 at 04:12:14AM +0000, Alex Arvelaez wrote: > On Wed, Feb 21, 2018 at 10:20:07PM -0500, valdis.kletnieks@xxxxxx wrote: > > On Thu, 22 Feb 2018 02:33:08 +0000, Alex Arvelaez said: > > > Hello, > > > > > > I'd like to contribute to the linux kernel eventually but I'm not sure > > > > https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.html > > > > > how, I grabbed a copy of the source code and I found a FIXME that looks > > > like I could fix: > > > > > > /* File: /usr/src/linux/tools/perf/util/string.c > > > * FIXME: replace this with an expression using log10() when we > > > * find a suitable implementation, maybe the one in the dvb drivers... > > > */ > > > > Step 0: Verify that the comment still matches the code, *and* that the change > > is still desired. Hint: Why do they want log10()? What does the current code > > do? What, if anything, will break if you change it? > I went ahead and used log10() from -lm, everything seems to work properly from what I can see. I made a patch with my changes should I send that to the linux-kernel mailing list for feedback? Regards, Alex _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
