Re: Understanding get_maintainer.pl and MAINTAINERS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Robin Krahl <robin.krahl@xxxxxxxxx> writes:

> Hi again,
>
> I’m now preparing my patchset for bcm2835-audio.  get_maintainer.pl
> returns:
>
> 	$ ./scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback drivers/staging/vc04_services/bcm2835-audio/
> 	Stephen Warren <swarren@xxxxxxxxxxxxx> (maintainer:BROADCOM BCM2835 ARM ARCHITECTURE)
> 	Lee Jones <lee@xxxxxxxxxx> (maintainer:BROADCOM BCM2835 ARM ARCHITECTURE)
> 	Eric Anholt <eric@xxxxxxxxxx> (maintainer:BROADCOM BCM2835 ARM ARCHITECTURE)
> 	Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> (supporter:STAGING SUBSYSTEM)
> 	Florian Fainelli <f.fainelli@xxxxxxxxx> (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...)
> 	Ray Jui <rjui@xxxxxxxxxxxx> (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...)
> 	Scott Branden <sbranden@xxxxxxxxxxxx> (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...)
> 	bcm-kernel-feedback-list@xxxxxxxxxxxx (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...)
> 	linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx (moderated list:BROADCOM BCM2835 ARM ARCHITECTURE)
> 	linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated list:BROADCOM BCM2835 ARM ARCHITECTURE)
> 	devel@xxxxxxxxxxxxxxxxxxxx (open list:STAGING SUBSYSTEM)
> 	linux-kernel@xxxxxxxxxxxxxxx (open list)
>
> Why are the BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE guys added
> to the list?  The MAINTAINERS file defines these rules:
>
> 	BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITECTURE
> 	M:      Florian Fainelli <f.fainelli@xxxxxxxxx>
> 	M:      Ray Jui <rjui@xxxxxxxxxxxx>
> 	M:      Scott Branden <sbranden@xxxxxxxxxxxx>
> 	M:      bcm-kernel-feedback-list@xxxxxxxxxxxx
> 	T:      git git://github.com/broadcom/mach-bcm
> 	S:      Maintained
> 	N:      bcm281*
> 	N:      bcm113*
> 	N:      bcm216*
> 	N:      kona
> 	F:      arch/arm/mach-bcm/
>
> As far as I see, none of these rules matches the given path.  Am I
> missing something?


The N entries are regex patterns.  "bcm281*" matches any name starting
with "bcm28", followed by 0 or more 1's.  So "bcm2835-audio" matches.

Yes, that looks like a bug in the MAINTAINERS entry.  They probably
intended something along 
 	N:      bcm281.*
 	N:      bcm113.*
 	N:      bcm216.*



Bjørn

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@xxxxxxxxxxxxxxxxx
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies




[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux