On Sat, Feb 04, 2017 at 04:20:53AM +0530, srishti sharma wrote: > I got this warning for a structure to be defined as constant , I have > fixed it by adding const , now this variable is not being used in this > file , so I was wondering if I should fix such warnings ? What if this > variable is used in some other file and the developer didn't want it > to be constant despite it producing a warning ? Maybe I am wrong . I have no idea what you are talking about, you are going to have to be a lot more specific, or even better yet, post your patch. But remember, you can only do "one thing" per patch, so don't try to do multiple things at the same time. Use a series of patches for that. good luck! greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
