On Fri, Dec 12, 2014 at 10:36:00PM -0800, Mandeep Sandhu wrote: > On Fri, Dec 12, 2014 at 8:02 PM, Greg KH <greg@xxxxxxxxx> wrote: > > On Fri, Dec 12, 2014 at 02:29:22PM -0800, Mandeep Sandhu wrote: > >> Thanks Greg! > >> > >> One more thing. Should the 'Tested-by:' tag be added in every commit > >> manually, or only one of them is enough (the last patch really > >> implements the functionality and the rest are 'preparatory' commits)? > > > > "Tested-by" is only for people who test the patch, not for the people > > who wrote the patch. It is implied that the person who wrote the patch > > also tested it, otherwise they shouldn't be sending the patch in the > > firat place, right? > > Right, although in my case, I'm not the original author of this patch. > This is the uio hotplug patch that I talked to you about on this ML a > few days back (which somehow missed inclusion almost 4 years back). Ok, then yes, add a tested-by on every patch that you tested. > I'm simply following your suggestion, that is re-submitting the patch > (after making some minor modifications to it for making it work with > newer kernels). The original patch author is "Eric W. Biederman". I > have tested this patch for my use-case (with a PCIE hotplug device) > and I have also written a small "fake hotplug" driver which validates > this patch (https://github.com/mandeepsandhu/uio-hotplug-test). > > Let me know if this is not the appropriate way to submit the patch (if > only the original author should submit it instead). Have you asked the original author about this? There has to be some reason the patch was not accepted, right? Try asking them what happened to see if they remember. I can't remember what happened with a specific patch yesterday, I deal with too many patches to be able to remember anything, but usually the author has a bit better recollection. It's ok to submit other people's patches, but it's a nice idea to ask them about it before doing so. good luck, greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
