On Fri, Dec 12, 2014 at 8:02 PM, Greg KH <greg@xxxxxxxxx> wrote: > On Fri, Dec 12, 2014 at 02:29:22PM -0800, Mandeep Sandhu wrote: >> Thanks Greg! >> >> One more thing. Should the 'Tested-by:' tag be added in every commit >> manually, or only one of them is enough (the last patch really >> implements the functionality and the rest are 'preparatory' commits)? > > "Tested-by" is only for people who test the patch, not for the people > who wrote the patch. It is implied that the person who wrote the patch > also tested it, otherwise they shouldn't be sending the patch in the > firat place, right? Right, although in my case, I'm not the original author of this patch. This is the uio hotplug patch that I talked to you about on this ML a few days back (which somehow missed inclusion almost 4 years back). I'm simply following your suggestion, that is re-submitting the patch (after making some minor modifications to it for making it work with newer kernels). The original patch author is "Eric W. Biederman". I have tested this patch for my use-case (with a PCIE hotplug device) and I have also written a small "fake hotplug" driver which validates this patch (https://github.com/mandeepsandhu/uio-hotplug-test). Let me know if this is not the appropriate way to submit the patch (if only the original author should submit it instead). Thanks for your time. Regards, -mandeep > > Hope this helps, > > greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
