Hey Greg, I am trying to improve my code as much as possible now, I really am finally understanding how terrible my code was before and I hope never again to make patches that shitty. Cheers Nick On 14-10-28 02:06 PM, Greg Donald wrote: > On Tue, Oct 28, 2014 at 12:53 PM, Nick Krause <xerofoify@xxxxxxxxx> wrote: >> I actually fixed this to improve code readability not for the kernel >> rules for your information. > > I know, good job.. and here's to hoping a maintainer picks up your > patch and applies it to their tree :) > > But I would argue "kernel rules" and "improving code readability" are > one and the same. Otherwise checkpatch and it's optional -f needn't > exist. > > _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies