On Tue, Oct 28, 2014 at 4:24 AM, Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> wrote: > On Sun, Oct 26, 2014 at 12:52 PM, Nicholas Krause <xerofoify@xxxxxxxxx> wrote: >> Fix all opening and closing braces issues reported by checkpatch. >> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx> >> --- >> drivers/staging/rtl8723au/core/rtw_ap.c | 138 ++++++++++---------------------- >> 1 file changed, 43 insertions(+), 95 deletions(-) > > Good job Nick, don't let the compliment go to your head now. I am > going to be very nitpicky because of past patch problems, so with that > said, the patch description could be improve a little. I know that > with simple changes like this, it is tough to not repeat yourself > (i.e. title is the same as the description). Currently the title and > patch description are ok, but personally I prefer that the patch > description be more verbose and not an copy of the patch title. So in > this case, a patch description of: > > "Fix the curley braces that do not reside on the same line because > this does not follow the kernel coding style and causes checkpatch.pl > warnings." That's actually important. Using checkpatch to identify potential problems is smart, but you fix them because the violate the kernel coding standard and there is no overriding reason to allow the violation. Lots of violations checkpatch finds are intentionally left in place because correcting them makes the code less readable, not more readable. Greg -- Greg Freemyer _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
