> > I checked that cpuidle_devices is only being used in cpuidle.c - hence > > thought that it can be made static and be removed from header. > > "cpuidle_devices" is actually used in drivers/cpuidle/coupled.c as well > so this breaks the build. Darn! I forgot 'clean build' part. sorry. > Even for "cpuidle_dev" the patch isn't right. It doesn't fix the > warning, for me. The DEFINE_PER_CPU() macro defines several variables > actually. Per CPU variables are a bit complicated and they have to have > globally unique names. So just ignore the Sparse warning for per CPU > variables. > Ok, let me look at my sparse log once again, will pick some other problem (any suggestions?) > There are several other "process" problems with the patch submission. > > 1) Incorrect subject. It should be: > [PATCH] cpuidle: make a variable static > > This is based on `git log --oneline drivers/cpuidle/cpuidle.c` > output. > > 2) No blank line between subject and body of commit message. > 3) Line wrap the body of the email at 72 characters. > 4) No Signed-off-by line. > Ok, will keep this in mind Thanks and Regards, Sagar _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
