On Sun, Sep 09, 2007 at 03:23:44PM -0400, Robert P. J. Day wrote: > > it occurred to me as i was perusing some of the source files that > some of those files were including module.h for no other reason than > to have access to the EXPORT_* macros. but why are those macros in > module.h? Because the users of the symbols defined by those macros are in modules. > they're not tied specifically to modules. for example, the file > kernel/mutex.c can't possibly be selected to be a module, and yet it > has to include that header file. That's because it wants to export those symbols for use by modules. > wouldn't it make more sense to have the EXPORT and symbol stuff in, > perhaps, kernel.h? or some other, lower-level header file that would > remove the need for including module.h in a file that has absolutely > nothing to do with modules? Maybe that would make a bit more sense, but is it really worth the change? Are you seeing massive slowdowns in the build due to including module.h? Or just getting annoyed that you have to rebuild the world when you touch that file? :) thanks, greg k-h -- To unsubscribe from this list: send an email with "unsubscribe kernelnewbies" to ecartis@xxxxxxxxxxxx Please read the FAQ at http://kernelnewbies.org/FAQ
