Re: [patch 13/20] chardev: GPIO for PC8736x: finally!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jesper Juhl wrote:


[ edited liberally - with implied ACKs/AGREEs ]




[snip]
+/** add this soon
+
+static u32 pc8736x_gpio_configure_event(unsigned index, u32 mask, u32 bits)
+{
+       return pc8736x_gpio_configure_fn(index, mask, bits,
+                                        SIO_GPIO_PIN_EVENT);
+}
+**/

If it's not needed now, why not just delay it's inclusion until it
really is needed?

bad habit of mine - leaving myself breadcrumbs.
I guess I should retrain myself ..


Perhaps make these inline?
Dunno if it'll make sense, but they just look like obvious inline candidates :)


These funcs are are called from the nsc_gpio_ops v-table, so they need real addys.


thanks again Jesper,
Jim Cromie

--
Kernelnewbies: Help each other learn about the Linux kernel.
Archive:       http://mail.nl.linux.org/kernelnewbies/
FAQ:           http://kernelnewbies.org/faq/


[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux