Re: [patch 03/20] chardev: GPIO for SCx200: add a platform device so dev_dbg() works

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/06/06, Jim Cromie <jim.cromie@xxxxxxxxx> wrote:

Add a platform-device, then use it for dev_dbg(), once, just to prove it
works.

[snip]
+       /* should I export-gpl the pci-device available in scx200,
+          and use it instead of getting my own platform/isa device ?
+       */

I'd suggest finding that out and correct it before submitting for
inclusion instead of just leaving the question in a comment.


[snip]
+       // what about chrdev cleanup ?

Use C comments, please, not C++ comments.


--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

--
Kernelnewbies: Help each other learn about the Linux kernel.
Archive:       http://mail.nl.linux.org/kernelnewbies/
FAQ:           http://kernelnewbies.org/faq/


[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux