On 3/18/06, Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote: > On Fri, 2006-03-17 at 22:38 +0000, Bahadir Balban wrote: > > So as a result do you imply that (2) and (3) are acceptable (or even > > good) ways of accessing device registers? > > yes > > personally I have a slight preference for (2) actually but that's just > taste. > One last question, if the registers are scattered in device memory, then wouldn't (2) need structure padding, and dont you think that would bloat the code? e.g. drivers/net/e100.c line 406. Thanks, Bahadir -- Kernelnewbies: Help each other learn about the Linux kernel. Archive: http://mail.nl.linux.org/kernelnewbies/ FAQ: http://kernelnewbies.org/faq/
