Re: ioctl driver call additional info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg KH wrote:

> On Mon, May 13, 2002 at 10:33:00AM -0500, David Stroupe wrote:
> 
>>#define THECALL _IOWR(UNIQUEMAGIC, 0x0d, DMA)
>>
> 
> This is correct, but your ioctl() call in your driver is getting a * to
> the structure, not the structure itself.  Also remember to call
> copy_from_user() on the data before you start using it within the
> kernel.
> 
> Hope this helps,
> 
> greg k-h
> 


Thanks for clearing that up!!!

In my driver I am doing this:

DMA temp;

copy_from_user(&temp, (DMA)arg, sizeof(DMA));
.
.
.
copy_to_user((DMA)arg, &temp, sizeof(DMA));

I have noticed that if the passed stuff (DMA) size approaches a page 
(0x1000) in size I start to see the problem....is there a size limit 
involved here?  I do see references to page faults in any oops that may 
occur if this call crashes.

Thanks again
David

--
Kernelnewbies: Help each other learn about the Linux kernel.
Archive:       http://mail.nl.linux.org/kernelnewbies/
FAQ:           http://kernelnewbies.org/faq/


[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux