Hi, >It would be nice if you could > * resolve the inconsistencies in indentation. Specifically, use tabs > to indent statements. If in doubt, use scripts/Lindent >and scripts/checkpatch.pl from linux. Done. Patch passes checkpatch.pl except for: - nf_conntrack_tuple.h and nf_nat.h in include/net/netfilter/; these two files are copied frome kernel tree; - lack of signed-off which AFAIK is used for kernel patches only; I hope it's ok. > * wrap lines at 80 cols in xt_DNETMAP.man Done. Updated versions are located here: http://cat.piasta.pl/dnetmap/xtables-addons-1.31-dnetmap-1.0.tar.bz2 http://cat.piasta.pl/dnetmap/xtables-addons-1.31-dnetmap-1.0.patch.bz2 >Things I have noticed while spending a quick look: >The manpage mentions "If host 192.168.0.10 generates some traffic, it >gets bound to first free IP in subnet - 20.0.0.0.". However, >20.0.0.0 can be a network address and thus lead to problems. >Is there a way for the user to specify that the range to use >should be 20.0.0.1-20.255.255.254 rather than 20.0.0.0-20.255.255.255? To address your concerns I've added new module parameter: whole_prefix: use network and broadcast addresses of specified prefix for bindings (default: 1) (uint) Implementing this as target parameter would be messy because data structures for a given prefix are created on addition of the first rule for a given prefix. best regards, Marek Kierdelewicz -- To unsubscribe from this list: send the line "unsubscribe netfilter" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
