Hi Eric. On Fri, Dec 04, 2009 at 02:46:54PM +0100, Eric Dumazet (eric.dumazet@xxxxxxxxx) wrote: > First patch changes __inet_hash_nolisten() and __inet6_hash() > to get a timewait parameter to be able to unhash it from ehash > at same time the new socket is inserted in hash. > > This makes sure timewait socket wont be found by a concurrent > writer in __inet_check_established() Both patches look good, although trick with returning reference counter may look like a hack especially when only viewing into ip code and not hashtable itself. Can you please cook up a documentation update for hash function that it is supposed to return refcnt when socket was in hash table. -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe netfilter" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
