Re: ECN mangling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



there's a bug in that code: in the netfilter-devel mailing list a patch was posted:

> 90 diffs[0] = diffs[0] ^ 0xFFFF;
> 91 diffs[1] = *tcpflags;

that does the job.
andrea

Athan wrote:
Looking at latest CVS there doesn't seem to be any changes to the code
in net/ipv4/netfilter/ipt_ECN.c. Not being uptospeed with how the code
all works it looks like it should be working:

89 if (diffs[0] != *tcpflags) {
90 diffs[0] = htons(diffs[0]) ^ 0xFFFF;
91 diffs[1] = htons(*tcpflags);
92 tcph->check = csum_fold(csum_partial((char *)diffs,
93 sizeof(diffs),
94 tcph->check^0xFFFF));
95 (*pskb)->nfcache |= NFC_ALTERED;
96 97 return 1;
98 }

But it obviously isn't.

-Ath


[Index of Archives]     [Linux Netfilter Development]     [Linux Kernel Networking Development]     [Netem]     [Berkeley Packet Filter]     [Linux Kernel Development]     [Advanced Routing & Traffice Control]     [Bugtraq]

  Powered by Linux