On Wed, Sep 04, 2024 at 06:48:10PM +0800, Mikhail Ivanov wrote:
> Add test that validates behaviour of Landlock after rule with
> unknown access is added.
>
> Signed-off-by: Mikhail Ivanov <ivanov.mikhail1@xxxxxxxxxxxxxxxxxxx>
> ---
> Changes since v2:
> * Replaces EXPECT_EQ with ASSERT_EQ for close().
> * Refactors commit title.
>
> Changes since v1:
> * Refactors commit messsage.
> ---
> .../testing/selftests/landlock/socket_test.c | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/tools/testing/selftests/landlock/socket_test.c b/tools/testing/selftests/landlock/socket_test.c
> index cb23efd3ccc9..811bdaa95a7a 100644
> --- a/tools/testing/selftests/landlock/socket_test.c
> +++ b/tools/testing/selftests/landlock/socket_test.c
> @@ -325,4 +325,30 @@ TEST_F(protocol, socket_access_rights)
> ASSERT_EQ(0, close(ruleset_fd));
> }
>
> +TEST_F(protocol, rule_with_unknown_access)
> +{
> + const struct landlock_ruleset_attr ruleset_attr = {
> + .handled_access_socket = ACCESS_ALL,
> + };
> + struct landlock_socket_attr protocol = {
> + .family = self->prot.family,
> + .type = self->prot.type,
> + };
> + int ruleset_fd;
> + __u64 access;
> +
> + ruleset_fd =
> + landlock_create_ruleset(&ruleset_attr, sizeof(ruleset_attr), 0);
> + ASSERT_LE(0, ruleset_fd);
> +
> + for (access = 1ULL << 63; access != ACCESS_LAST; access >>= 1) {
> + protocol.allowed_access = access;
> + EXPECT_EQ(-1,
> + landlock_add_rule(ruleset_fd, LANDLOCK_RULE_SOCKET,
> + &protocol, 0));
> + EXPECT_EQ(EINVAL, errno);
> + }
> + ASSERT_EQ(0, close(ruleset_fd));
> +}
> +
> TEST_HARNESS_MAIN
> --
> 2.34.1
>
Reviewed-by: Günther Noack <gnoack@xxxxxxxxxx>
