Donald Hunter <donald.hunter@xxxxxxxxx> wrote: > Florian Westphal <fw@xxxxxxxxx> writes: > > > This update allows listing default firewalld ruleset on Fedora 40 via > > tools/net/ynl/cli.py --spec \ > > Documentation/netlink/specs/nftables.yaml --dump getrule > > > > Default ruleset uses fib, reject and objref expressions which were > > missing. > > > > Other missing expressions can be added later. > > > > Improve decoding while at it: > > - add bitwise, ct and lookup attributes > > - wire up the quota expression > > - translate raw verdict codes to a human reable name, e.g. > > 'code': 4294967293 becomes 'code': 'jump'. > > > > Cc: Donald Hunter <donald.hunter@xxxxxxxxx> > > Signed-off-by: Florian Westphal <fw@xxxxxxxxx> > > One minor question below, otherwise LGTM. > > Reviewed-by: Donald Hunter <donald.hunter@xxxxxxxxx> > > > > + name: fib-result > > + type: enum > > + entries: > > + - oif > > + - oifname > > Did you intentionally leave out addrtype from the enum? No, I'm just incompetent. Will send a v2 tomorrow.