Re: [PATCH net-next] netlink: specs: nftables: allow decode of default firewalld ruleset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Florian Westphal <fw@xxxxxxxxx> writes:

> This update allows listing default firewalld ruleset on Fedora 40 via
>   tools/net/ynl/cli.py --spec \
>      Documentation/netlink/specs/nftables.yaml --dump getrule
>
> Default ruleset uses fib, reject and objref expressions which were
> missing.
>
> Other missing expressions can be added later.
>
> Improve decoding while at it:
> - add bitwise, ct and lookup attributes
> - wire up the quota expression
> - translate raw verdict codes to a human reable name, e.g.
>   'code': 4294967293 becomes 'code': 'jump'.
>
> Cc: Donald Hunter <donald.hunter@xxxxxxxxx>
> Signed-off-by: Florian Westphal <fw@xxxxxxxxx>

One minor question below, otherwise LGTM.

Reviewed-by: Donald Hunter <donald.hunter@xxxxxxxxx>


> +    name: fib-result
> +    type: enum
> +    entries:
> +      - oif
> +      - oifname

Did you intentionally leave out addrtype from the enum?




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux