On 4/24/24 16:58, Phil Sutter wrote:
Thanks for the explanation. I don't quite get how a build is deterministic if libnfnetlink presence is not, but OK.
If you specify either command line option, the outcome of the build (if it is successful) depends only on that option:
- if the option disables support, it will be disabled regardless of whether the needed library is present
- if the option enables support, either it will be enabled, or the build will error out with a missing library message, avoiding the situation where support was requested, but quietly disabled because library wasn't found.
The problem I see with the patch is the changed default behaviour. Could you please retain the conditional build if neither --enable-libnfnetlink nor --disable-libnfnetlink was specified?
I sent a v2 that retains autodetection, can you please check that? -- Alexander Kanavin Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen Phone: +49 7556 25 999 39; Fax.: +49 7556 25 999 99 Hinweise zum Datenschutz finden Sie hier (Informations on data privacy can be found here): https://linutronix.de/legal/data-protection.php Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner Tiffany Silva, Sean Fennelly, Jeffrey Schneiderman
