On 4/24/24 14:53, Phil Sutter wrote:
Hi,
On Wed, Apr 24, 2024 at 02:28:04PM +0200, Alexander Kanavin wrote:
From: "Maxin B. John" <maxin.john@xxxxxxxxx>
This changes the configure behaviour from autodetecting
for libnfnetlink to having an option to disable it explicitly.
Signed-off-by: Khem Raj <raj.khem@xxxxxxxxx>
Signed-off-by: Maxin B. John <maxin.john@xxxxxxxxx>
Signed-off-by: Alexander Kanavin <alex@xxxxxxxxxxxxx>
The patch looks fine as-is, I wonder though what's the goal: Does the
build system have an incompatible libnfnetlink which breaks the build?
It is used by nfnl_osf only, right? So maybe introduce
| AC_ARG_ENABLE([nfnl_osf], ...)
instead?
The patch is very old, and I didn't write it (I'm only cleaning up the
custom patches that yocto project is currently carrying). It was
introduced for the purposes of ensuring build determinism and
reproducibility: so that libnfnetlink support doesn't get quietly
enabled or disabled depending on what is available in the build system,
but can be reliably turned off or on.
Note that we also carry a related patch which I didn't look at properly
yet, but can submit as well:
https://git.yoctoproject.org/poky/tree/meta/recipes-extended/iptables/iptables/0004-configure.ac-only-check-conntrack-when-libnfnetlink-.patch
--
Alexander Kanavin
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 39; Fax.: +49 7556 25 999 99
Hinweise zum Datenschutz finden Sie hier (Informations on data privacy
can be found here): https://linutronix.de/legal/data-protection.php
Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen |
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner
Tiffany Silva, Sean Fennelly, Jeffrey Schneiderman
