Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > > + struct nlattr *udata; > > May I suggest to use our own data structure, instead of using nlattr? > It is just a bit misleading to the reader. > > But maybe I need to get used to this and that's all, your call. I have no preference. I thought reusing nlattr was simpler because you can just kmemdup the nlattr+header. I'll leave it up to patch author, no strong opinion either.