Re: [PATCH nft] tests: shell: flush ruleset with -U after feature probing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, Dec 06, 2023 at 01:45:21PM +0100, Thomas Haller wrote:
> On Wed, 2023-12-06 at 13:14 +0100, Pablo Neira Ayuso wrote:
> > On Wed, Dec 06, 2023 at 07:47:44AM +0100, Thomas Haller wrote:
> > 
> > 
> > I can keep it out of tree if you prefer -U remains broken.
> IMO the mode definitely should be fixed, as much as possible.
> Also, I think the patch is fine. Especially if it fixes an obvious
> issue.
> If -U is well supported, then tests and feature-detection should take
> special care to remove interfaces they create. Maybe they could all use
> well-known interfaces names (fwtst0, fwtst1, fwtst2). Then
> and could automatically clean up those interfaces. It
> doesn't scale to let each test re-implement such cleanup.

I agree with Florian and you that removing toggles is a good idea, but
this one is useful for me at this stage, we revisit later on. There is
a specific tests infra for the monitor mode but it is rather limited.
I can also crash nft monitor with a few scenarios I am looking at to
fix it. Maybe -U can go away in the near future and monitor tests can
get better coverage.

> > This provides an easy way for me to test 'nft monitor'.
> OK then.


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux