Re: [PATCH nft] tests: shell: flush ruleset with -U after feature probing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2023-12-06 at 13:14 +0100, Pablo Neira Ayuso wrote:
> On Wed, Dec 06, 2023 at 07:47:44AM +0100, Thomas Haller wrote:
> 
> 
> I can keep it out of tree if you prefer -U remains broken.


IMO the mode definitely should be fixed, as much as possible.
Also, I think the patch is fine. Especially if it fixes an obvious
issue.

If -U is well supported, then tests and feature-detection should take
special care to remove interfaces they create. Maybe they could all use
well-known interfaces names (fwtst0, fwtst1, fwtst2). Then run-test.sh
and test-wrapper.sh could automatically clean up those interfaces. It
doesn't scale to let each test re-implement such cleanup.


> This provides an easy way for me to test 'nft monitor'.

OK then.


Thomas






[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux