On Fri, 2023-11-03 at 13:26 +0100, Florian Westphal wrote:
> Thomas Haller <thaller@xxxxxxxxxx> wrote:
>
> Thanks for sending an initial empty skeleton.
>
> > There are new new make targets:
> >
> > - "build-all"
> > - "check" (runs "normal" tests, like unit tests and "tools/check-
> > tree.sh").
> > - "check-more" (runs extra tests, like "tests/build")
> > - "check-all" (runs "check" + "check-more")
> > - "check-local" (a subset of "check")
> > - "check-TESTS" (the unit tests)
>
> "check-unit" perhaps? TESTS isn't very descriptive. Also,
> why CAPS? If this is some pre-established standard, then maybe just
> document that in the commit changelog.
"TESTS" is an autotools/automake thing. "check-TESTS" runs the tests
that are setup via "TESTS=".
AFAIU, with autotools, `make check` basically runs the targets `make
check-local` and `make check-TESTS`.
Anyway, I can just alias it via:
check-unit: check-TESTS
Note that other targets are currently called
`make check-tests-build`
`make check-tests-shell` (patch not yet send).
It reminds of the directories "tests/{build,shell,unit}" and would lead
to a name `make check-tests-unit`.
But reconsidering, in v2 I will drop this "check-tests-" prefix then
and call them just "check-{unit,build,shell}".
>
> Please don't do anything yet and wait for more comments, but
> I would prefer 'make check' to run all tests that we have.
currently `make check-more` only entails `make check-tests-build` (i.e.
`tests/build/run-tests.sh`). Note that
- `tests/build/run-tests.sh` calls `make distcheck`
- `make distcheck` runs `make check`.
I don't think it would make sense, to include the build check in `make
check`.
So I think there is a (small) place for "check-more" (and thus "check-
all"). But yes, probably most other tests should be included by the
common `make check`!
>
> I would suggest
> - "check" (run all tests)
> - "check-unit" (the unit tests only)
> - "check-shell" (shell tests only)
> - "check-py" (python based tests only)
> - "check-json" (python based tests in json mode and json_echo)
>
> ... and so on.
>
ACK. Will send in v2.
