On Thu, Nov 02, 2023 at 05:53:43PM +0100, Thomas Haller wrote: > On Thu, 2023-11-02 at 17:05 +0100, Pablo Neira Ayuso wrote: [...] > > But this is completely inconsistent with what we have in other > > existing Netfilter trees. > > That would also be fixable, by adjusting those trees (I'd volunteer). > > The question is what's better, and not what the projects copy-pasted > since 1995 do. I don't think it is worth the update, maybe some simplification to remove silly things such as Makefile.am with one singleton line, but there are better things to look at IMO. [...] > > Please do not couple tests with make process. > > On the branch, those tests work and it's convenient to run them and > reasonably fast! `make -j distcheck` takes 59 seconds on my machine. CI is what is missing, a single run is proving not giving much in return these days after your improvements. The recent bugs that were uncovered have been spotted by running this is a loop, and also exercising standalone 30s-stress from Florian for many hours. A few minutes does not harm (I can check how long it takes on my AMD Epyc box that I use for testing), but CI might provide more reliable information on what is going on. Thanks.
