On Thu, 2023-11-02 at 16:54 +0100, Pablo Neira Ayuso wrote:
> On Thu, Nov 02, 2023 at 03:09:42PM +0100, Thomas Haller wrote:
> >
> > I think BUG() would not work. This does happen, as the tests in
> > patches
> >
> > Subject: [PATCH nft 0/7] add and check dump files for JSON
> > in tests/shell
> > Date: Tue, 31 Oct 2023 19:53:26 +0100
> >
> > expose.
>
> No listing from the kernel would use the variable expression.
>
> What example would be triggering bug?
when you apply above patchset (and revert patch 2/7), and:
$ make
$ ./tests/shell/run-tests.sh
...
$ grep '^[^ ]*W[^ ]*:' /tmp/nft-test.latest.*/test.log
W: [CHK DUMP] 8/381 tests/shell/testcases/chains/0041chain_binding_0
W: [CHK DUMP] 66/381 tests/shell/testcases/cache/0010_implicit_chain_0
W: [CHK DUMP] 226/381 tests/shell/testcases/nft-f/sample-ruleset
$ grep -R 'Command `./tests/shell/../../src/nft -j list ruleset""` failed' /tmp/nft-test.latest.*/
...
Gives:
tests/shell/testcases/nft-f/sample-ruleset
tests/shell/testcases/cache/0010_implicit_chain_0
tests/shell/testcases/chains/0041chain_binding_0
For example:
/tmp/nft-test.latest.thom/test-tests-shell-testcases-chains-0041chain_binding_0.4/rc-failed-chkdump:Command `./tests/shell/../../src/nft -j list ruleset""` failed
/tmp/nft-test.latest.thom/test-tests-shell-testcases-chains-0041chain_binding_0.4/rc-failed-chkdump:>>>>
/tmp/nft-test.latest.thom/test-tests-shell-testcases-chains-0041chain_binding_0.4/rc-failed-chkdump:warning: stmt ops chain have no json callback
/tmp/nft-test.latest.thom/test-tests-shell-testcases-chains-0041chain_binding_0.4/rc-failed-chkdump:warning: stmt ops chain have no json callback
/tmp/nft-test.latest.thom/test-tests-shell-testcases-chains-0041chain_binding_0.4/rc-failed-chkdump:<<<<
There are also other failures. e.g.
tests/shell/testcases/parsing/large_rule_pipe does not give stable
output. I need to drop that .json-nft file in v2.
Using Fedora kernel 6.5.6-300.fc39.x86_64.
Thomas
