On 2023/08/09 0:32, Gustavo A. R. Silva wrote:
>
> [...]
>
>> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
>> index 757ec46fc45a..5ec66b1ebb64 100644
>> --- a/net/bridge/netfilter/ebtables.c
>> +++ b/net/bridge/netfilter/ebtables.c
>> @@ -2115,8 +2115,7 @@ static int size_entry_mwt(const struct ebt_entry *entry, const unsigned char *ba
>> return ret;
>>
>> offsets[0] = sizeof(struct ebt_entry); /* matches come first */
>> - memcpy(&offsets[1], &entry->watchers_offset,
>> - sizeof(offsets) - sizeof(offsets[0]));
>> + memcpy(&offsets[1], &entry->offsets, sizeof(offsets) - sizeof(offsets[0]));
> ^^^^^^^^^^^^
> You now can replace this ____________________________________|
> with just `sizeof(entry->offsets)`
>
> With that change you can add my
> Reviewed-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
>
> Thank you
> --
> Gustavo
>
Will do. Thanks for the suggestion & review!
>>
>> if (state->buf_kern_start) {
>> buf_start = state->buf_kern_start + state->buf_kern_offset;
>> --
>> 2.41.0
>>
